chore(composer): add missing blackbox tests #1834
Open
+342
−667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
commented
Nov 27, 2024
| }) | ||
| .await | ||
| .unwrap(); | ||
| time::timeout(Duration::from_millis(1000), async { |
There was a problem hiding this comment.
This sometimes times out, even when increasing the timeout time. Unsure as to if this is a problem with the test or something flaky about composer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added blackbox tests to cover whitebox tests which were removed in #1643.
Background
Tests were removed in #1643 because the internal tests were very whitebox-y and fragile. They have not yet been added back as blackbox tests.
Changes
bundle_triggered_by_block_timer,two_seq_actions_single_bundle, andchain_id_mismatch_returns_error.Testing
Passing all tests
Changelogs
No updates required.
Related Issues
closes #1652